-
Notifications
You must be signed in to change notification settings - Fork 6.8k
chore: add example for ripple #12063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add example for ripple #12063
Conversation
* Moves the ripple demo into a more bare-bone example that can shown in the docs at some point. References angular#7543
4381a96
to
64cd49c
Compare
margin: 6px 12px 6px 0; | ||
} | ||
|
||
mat-form-field { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use css classes for these styles instead of styling the elements directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I didn't intend to use a class here because I felt like it would bloat the example HTML and since we have view encapsulation turned on for the examples, it wouldn't affect other things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something I insist on because it makes it easier for people inspecting the demos to know the difference between the component styles and the example styles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
References #7543